Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(docker: toolchain): compatibility with latest WAF versions #2917

Closed
wants to merge 6 commits into from

Conversation

Leiyks
Copy link
Contributor

@Leiyks Leiyks commented Oct 30, 2024

Description

Update the Toolchain Docker image to make it compatible with the later versions of the WAF.

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

Related Jiras: APPSEC-55607

@Leiyks Leiyks force-pushed the leiyks/upgrade-docker-llvm-version branch from 403036c to 7ba1b25 Compare October 30, 2024 10:06
@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.38%. Comparing base (a1ec6f8) to head (ed92c43).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2917      +/-   ##
============================================
- Coverage     72.39%   72.38%   -0.01%     
  Complexity     2527     2527              
============================================
  Files           135      135              
  Lines         14399    14399              
  Branches        989      989              
============================================
- Hits          10424    10423       -1     
- Misses         3432     3433       +1     
  Partials        543      543              
Flag Coverage Δ
appsec-extension 68.34% <ø> (ø)
tracer-php 73.96% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1ec6f8...ed92c43. Read the comment docs.

@realFlowControl
Copy link
Member

FYI: with #2758 we upgraded the toolchain for the tracer and profiler to LLVM 17

@Leiyks Leiyks force-pushed the leiyks/upgrade-docker-llvm-version branch from 7ba1b25 to 8c8249e Compare November 5, 2024 15:21
Leiyks and others added 4 commits November 6, 2024 10:39
Signed-off-by: Alexandre Rulleau <[email protected]>
 * Create linux_users group with gid=1000
 * Create linux_user with uid=1000
 * Simplify toolchain and include cmake release
 * Reinstate checksums and delete unnecessary files
@Leiyks Leiyks force-pushed the leiyks/upgrade-docker-llvm-version branch from 7be87fc to f2143b7 Compare November 6, 2024 09:39
@Leiyks Leiyks changed the title test(docker: toolchain): upgrade to LLVM 16.0.6 test(docker: toolchain): compatibility with latest WAF versions Nov 6, 2024
@Leiyks Leiyks marked this pull request as ready for review November 6, 2024 12:55
@Leiyks Leiyks requested a review from a team as a code owner November 6, 2024 12:55
@Leiyks Leiyks closed this Nov 6, 2024
@Leiyks
Copy link
Contributor Author

Leiyks commented Nov 6, 2024

Changes from this PR has been integrated into this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants